-
Notifications
You must be signed in to change notification settings - Fork 15
[object Object].removeClassFromAllLines is deprecated. #49
Comments
👍 |
Thanks for bringing this up, when I get a bit of time i'll do this |
Great. Thanks for the reply. That exclamation mark is annoying :) |
I started a fix for this but didn't complete it. Some info on how to do it here: https://discuss.atom.io/t/how-to-highlight-line-or-region-from-package/9871/25 |
I've finished a rough conversion using decorations: https://github.com/framerate/atom-jshint @Joezo - let me know your thoughts and if I should do a PR. It was super fast and my first atom plugin project, but I want to help get this fixed. Pretty much only changed this function: https://github.com/framerate/atom-jshint/blob/master/lib/atom-jshint.js#L172 edit: This rough version just highlights the lines red. Someone can maybe take it from there and make it pretty! edit again: This isn't done, but hoping to get the ball rolling! |
Thanks for looking at it, i'll take a look soon, just a little busy at the second :) |
@framerate if you could submit that as a pull request that'd be great! |
@Joezo - Done! I recommend someone else taking a look at it before deploying though! I worry that the loop/remove decorators isn't efficient? |
All deprecations are fixed in branch fix-deprecations, this will be published soon. Thanks for reporting the issue :) |
Use decorations instead: http://blog.atom.io/2014/07/24/decorations.html
The text was updated successfully, but these errors were encountered: