Skip to content
This repository has been archived by the owner on Jan 5, 2021. It is now read-only.

[object Object].removeClassFromAllLines is deprecated. #49

Closed
LukeMauldin opened this issue Aug 27, 2014 · 9 comments
Closed

[object Object].removeClassFromAllLines is deprecated. #49

LukeMauldin opened this issue Aug 27, 2014 · 9 comments

Comments

@LukeMauldin
Copy link

Use decorations instead: http://blog.atom.io/2014/07/24/decorations.html

[object Object].removeClassFromAllLines (/Applications/Atom 2.app/Contents/Resources/app/src/editor-view.js:95:13)
AtomJsHint.updateGutter (/Users/lmauldin/.atom/packages/atom-jshint/lib/atom-jshint.js:175:14)
AtomJsHint.resetState (/Users/lmauldin/.atom/packages/atom-jshint/lib/atom-jshint.js:139:10)
AtomJsHint.run (/Users/lmauldin/.atom/packages/atom-jshint/lib/atom-jshint.js:95:12)
AtomJsHint.<anonymous> (/Users/lmauldin/.atom/packages/atom-jshint/lib/atom-jshint.js:37:14)
@vogonistic
Copy link

👍

@Joezo
Copy link
Owner

Joezo commented Sep 1, 2014

Thanks for bringing this up, when I get a bit of time i'll do this

@briannhinton
Copy link

Great. Thanks for the reply. That exclamation mark is annoying :)

@framerate
Copy link

I started a fix for this but didn't complete it. Some info on how to do it here:

https://discuss.atom.io/t/how-to-highlight-line-or-region-from-package/9871/25

@framerate
Copy link

I've finished a rough conversion using decorations:

https://github.com/framerate/atom-jshint

@Joezo - let me know your thoughts and if I should do a PR. It was super fast and my first atom plugin project, but I want to help get this fixed.

Pretty much only changed this function: https://github.com/framerate/atom-jshint/blob/master/lib/atom-jshint.js#L172

edit: This rough version just highlights the lines red. Someone can maybe take it from there and make it pretty!

edit again: This isn't done, but hoping to get the ball rolling!

@Joezo
Copy link
Owner

Joezo commented Sep 3, 2014

Thanks for looking at it, i'll take a look soon, just a little busy at the second :)

@Joezo
Copy link
Owner

Joezo commented Sep 4, 2014

@framerate if you could submit that as a pull request that'd be great!

@framerate
Copy link

@Joezo - Done! I recommend someone else taking a look at it before deploying though! I worry that the loop/remove decorators isn't efficient?

@Joezo
Copy link
Owner

Joezo commented May 22, 2015

All deprecations are fixed in branch fix-deprecations, this will be published soon. Thanks for reporting the issue :)

@Joezo Joezo closed this as completed May 22, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants