Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid run-away root widening #96

Merged
merged 4 commits into from
Jun 20, 2023
Merged

avoid run-away root widening #96

merged 4 commits into from
Jun 20, 2023

Conversation

JohannesBuchner
Copy link
Owner

This is to address #81

A stopping is added to avoid a infinite loop.
A warning is added with user instructions.

@JohannesBuchner
avoid run-away root widening. closes #81
4b7d8b3 
A stopping is added to avoid a infinite loop.
A warning is added with user instructions.
@JohannesBuchner JohannesBuchner mentioned this pull request Jun 1, 2023
Closed
jpl-jengelke
jpl-jengelke reviewed Jun 1, 2023
View reviewed changes
Copy link

@jpl-jengelke jpl-jengelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes appear to be applied to private methods. How would you recommend that we change num_warn or num_stop from the public API?

@JohannesBuchner
Copy link
Owner Author

JohannesBuchner commented Jun 1, 2023 •
edited
Loading

Yes, I did not do that yet, this only stops the infinite loop. Hold on...

@JohannesBuchner
Copy link
Owner Author

Now there is: widen_before_initial_plateau_num_max and widen_before_initial_plateau_num_warn

@JohannesBuchner
add tests, pass arguments through
60fad8c 
passing the plateau (passing_node is slow)
@JohannesBuchner JohannesBuchner merged commit 5806aba into master Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpl-jengelke jpl-jengelke jpl-jengelke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohannesBuchner @jpl-jengelke