Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to normalize 7.0.0 #107

Closed
JohnAlbin opened this issue May 11, 2017 · 4 comments
Closed

Upgrade to normalize 7.0.0 #107

JohnAlbin opened this issue May 11, 2017 · 4 comments

Comments

@JohnAlbin
Copy link
Owner

Normalize 7.0.0 is out. https://github.com/necolas/normalize.css/releases

@garrettw
Copy link

Do you have any thoughts/feelings about whether opinionated rules should be included or not?

@JohnAlbin
Copy link
Owner Author

JohnAlbin commented May 13, 2017

I do, actually!

I prefer to fork normalize.css alter the rulesets to match what the particular project needs. That means having a scaffold for rules needed in my project, but not needed in a drop-in-and-forget version of normalize.css. For example, p { margin: 1.5rem 0 }

Fortunately, this project has both a mixin-based version of normalize and a fork-ready version of normalize. So I can keep my opinionated rules in the forks and, in the mixin-based normalize, follow the parent normalize.css project's direction of removing opinionated rules.

@garrettw
Copy link

What I'm referring to is the rules that version 6 removed and that version 7 is bringing back, due to the difference in vision of the two prior maintainers.

(And on that note, I have to ask: is that debacle the reason for your recent "code of conduct" commits?)

@JohnAlbin
Copy link
Owner Author

What I'm referring to is the rules that version 6 removed and that version 7 is bringing back

I'm just following whatever is in their code when deciding what goes in the mixin version of normalize-scss. Other contributers and users have expressed the desire that the default CSS output of the mixin should match the CSS in normalize.css.

And I will keep the opinionated rules that I like in the fork versions.

And on that note, I have to ask: is that debacle the reason for your recent "code of conduct" commits?

@garrettw Lol. No. It's unrelated to their disagreements. I've been meaning to add one to all my projects and I am finally getting around to adding them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants