Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Attraction Failed #175

Closed
rliu1026 opened this issue Dec 5, 2020 · 3 comments · Fixed by #183
Closed

Add Attraction Failed #175

rliu1026 opened this issue Dec 5, 2020 · 3 comments · Fixed by #183
Labels
bug Something isn't working

Comments

@rliu1026
Copy link
Collaborator

rliu1026 commented Dec 5, 2020

Summary: App crashes after searching and adding attraction

Description: In "Personal Tours" -> "Future Tours" -> "Add Attraction", when clicking on the an attraction in the searching results, the app exits to home screen. After reopening the app, all info filled in "Future Tours" form are lost.

Severity: Medium.

Suggestion: Check if the search result has been saved. Create storage buffer for form not yet submitted.

@rliu1026 rliu1026 added the bug Something isn't working label Dec 5, 2020
@rliu1026
Copy link
Collaborator Author

rliu1026 commented Dec 5, 2020

Here is an example I am able to reproduce:
Everytime I search for "Xuanwu Lake" (which is an attraction in Nanjing), as soon as I select a search result, the app exits to home screen.
image

But for some other attractions, it works perfectly when I clicked the result.
image

@rliu1026
Copy link
Collaborator Author

rliu1026 commented Dec 5, 2020

Here is a recording of the crash:
https://drive.google.com/file/d/1yQ1yXl7Oos8DXtpwKtoxDYQ35HqTFl2c/view?usp=sharing
I have tried twice and both attempts crashed, the second one with a prompt.

@Axiloom
Copy link
Owner

Axiloom commented Dec 7, 2020

@rliu1026 Thank you so much, this is extremely helpful!

@Axiloom Axiloom linked a pull request Dec 7, 2020 that will close this issue
@Axiloom Axiloom closed this as completed Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants