-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only async request and file writes #12
Conversation
avaldebe
commented
Feb 3, 2022
•
edited
Loading
edited
- close use async request library #10
- focused version of async request and file writes #11
- update docs config
- update RTD config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this approach! I tried it out a bit and it also seems like a significant speedup, nice work! Just a few questions and kinks to iron out.
Form the other PR, could you still add the documentation update too? 🙏
Thanks for slimming this down, it made it a lot more manageable to review. Do feel free to open issues/PRs addressing the other contributions from #11, I'm happy for the help, it was just too broad for a single PR.
@avaldebe if this is ready for a re-review just request it or let me know 😊 |
It is ready for re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! Thanks for contributing 🍰 ✨
I'm also going to switch the CI/CD over from Travis to GitHub actions right after this, then I'll do a new release.
I put a little acknowledgement to you in the README :) |