-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use async request library #10
Comments
Hey, thanks for checking out airbase! I've had something like this in mind for ages but just never got around to it. If I had done it myself I would probably go the |
Would need to bump the minimum python version up to Python 3.7 in order to use aiohttp: |
Given that this is often used in an academic setting, older Python versions are more common than one might hope 😬 I'd prefer 3.7 for that reason. |
I went a bit out of scope on PR #11. |
Hi @JohnPaton After adding type hints to all the functions,
Lines 313 to 324 in 8420903
I'm aware that normal usage of the library would not generate such a request, but I think it would be better to remove the default value for |
Hi John,
Have you considered to use an asynchronous request library?
Replacing
requests
byaiohttp
would give you concurrent downloads,like in the 3rd implementation shown on this article.
Would you accept a PR?
I have no experience with async python, but I'm willing to give it a try.
Cheers,
Álvaro.
The text was updated successfully, but these errors were encountered: