Skip to content

Commit

Permalink
validate rustc_allow_const_fn_unstable targets
Browse files Browse the repository at this point in the history
Adds a check to make sure `#[rustc_allow_const_fn_unstable]`
can be applied only to functions.
  • Loading branch information
liketechnik committed Oct 21, 2020
1 parent 7258740 commit 3a63bf0
Showing 1 changed file with 22 additions and 0 deletions.
22 changes: 22 additions & 0 deletions compiler/rustc_passes/src/check_attr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ impl CheckAttrVisitor<'tcx> {
self.check_rustc_args_required_const(&attr, span, target, item)
} else if self.tcx.sess.check_name(attr, sym::allow_internal_unstable) {
self.check_allow_internal_unstable(&attr, span, target, &attrs)
} else if self.tcx.sess.check_name(attr, sym::rustc_allow_const_fn_unstable) {
self.check_rustc_allow_const_fn_unstable(&attr, span, target)
} else {
// lint-only checks
if self.tcx.sess.check_name(attr, sym::cold) {
Expand Down Expand Up @@ -791,6 +793,26 @@ impl CheckAttrVisitor<'tcx> {
.emit();
false
}

/// Outputs an error for `#[allow_internal_unstable]` which can only be applied to macros.
/// (Allows proc_macro functions)
fn check_rustc_allow_const_fn_unstable(
&self,
attr: &Attribute,
span: &Span,
target: Target,
) -> bool {
if let Target::Fn | Target::Method(_) = target {
// FIXME Check that this isn't just a function, but a const fn
return true;
}
self.tcx
.sess
.struct_span_err(attr.span, "attribute should be applied to `const fn`")
.span_label(*span, "not a `const fn`")
.emit();
false
}
}

impl Visitor<'tcx> for CheckAttrVisitor<'tcx> {
Expand Down

0 comments on commit 3a63bf0

Please sign in to comment.