Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 #1589

Closed
kristapsk opened this issue Oct 29, 2023 · 6 comments · Fixed by #1707
Closed

Add support for Python 3.12 #1589

kristapsk opened this issue Oct 29, 2023 · 6 comments · Fixed by #1707
Labels
dependencies Pull requests that update a dependency file help wanted

Comments

@kristapsk
Copy link
Member

Currently tests on Python 3.12 are failing.

https://github.com/roshii/joinmarket-clientserver/actions/runs/6681650313/job/18155992988

https://github.com/roshii/joinmarket-clientserver/actions/runs/6681650313/job/18155993117

@kristapsk kristapsk added the dependencies Pull requests that update a dependency file label Oct 29, 2023
@kristapsk
Copy link
Member Author

See also #1587.

@svpi11
Copy link

svpi11 commented Nov 9, 2023

Would be great to make the Qt portable to python 3.12 :)

@kristapsk
Copy link
Member Author

Qt GUI should be ported to Qt 6 first, there are problems with it since Python 3.10. #1376

kristapsk added a commit that referenced this issue Jan 30, 2024
204f117 Drop Python 3.7 support (Kristaps Kaupe)

Pull request description:

  It's EOL since 27 Jun 2023 and 3.8+ is required for #1637.

  Also mentioned in docs that JoinMarket is currently not compatible with 3.12 (#1589).

ACKs for top commit:
  AdamISZ:
    utACK 204f117
  roshii:
    utACK 204f117

Tree-SHA512: 39ee96aca5e305b894e97a2a843d748a645becbfca1bc9e35f02f33c4634a4f7fee37fd36115510cc052e1d11497dceee2d0fafa12d006dd005d050e5ea1cc9f
@kristapsk
Copy link
Member Author

Trying to get install.sh --develop -p python3.12 --without-qt working on Ubuntu 22.04 under WSL.

Currently stuck with:

$ ./install.sh --develop -p python3.12 --without-qt
Directory jmvenv exists.  Remove and recreate? (y/N) y
Error: Command '['/home/user/git/joinmarket-clientserver/jmvenv/bin/python3.12', '-m', 'ensurepip', '--upgrade', '--default-pip']' returned non-zero exit status 1.
Joinmarket Python virtual environment could not be setup. Exiting.

ensurepip is called by python3.12 -m venv /home/user/git/joinmarket-clientserver/jmvenv.

Tried https://ubuntuhandbook.org/index.php/2023/10/fix-broken-pip-python-312-ubuntu/, but only installing pip with get-pip.py works for me, but that doesn't fix anything.

Are others experiencing the same with Python 3.12? Pretty sure it's not related to running Ubuntu under WSL.

@kristapsk
Copy link
Member Author

This currently seems to be the biggest issue regarding dependencies.

@roshii
Copy link
Contributor

roshii commented May 19, 2024

Are others experiencing the same with Python 3.12? Pretty sure it's not related to running Ubuntu under WSL.

I did manage install joinmarket with Python 12 on Alpine Linux 3.18 - tested directory node script which seem to work as expected.
I also tested install.sh --develop -without-qt with Python 3.12.3 installed via pyenv on Arch Linux: no issue encountered while installing.

Tests suite is now passing successfully. I shall create PR to reflect this: we are Python 12 compatible !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants