Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.7 support #1639

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

kristapsk
Copy link
Member

It's EOL since 27 Jun 2023 and 3.8+ is required for #1637.

Also mentioned in docs that JoinMarket is currently not compatible with 3.12 (#1589).

@kristapsk kristapsk added the dependencies Pull requests that update a dependency file label Jan 20, 2024
Copy link
Contributor

@roshii roshii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 204f117

@AdamISZ
Copy link
Member

AdamISZ commented Jan 30, 2024

utACK 204f117

@kristapsk kristapsk merged commit 658bb00 into JoinMarket-Org:master Jan 30, 2024
8 checks passed
@kristapsk kristapsk deleted the drop-python-3.7 branch January 30, 2024 17:15
kristapsk added a commit that referenced this pull request Feb 5, 2024
ca33eca Bump txtorcon from 23.0.0 to 23.11.0 (Kristaps Kaupe)

Pull request description:

  In #1567 we updated to 23.0.0, not 23.5.0, because that was the last version supporting Python 3.7. Now that Python 3.7 support is dropped with #1639, can upgrade to latest.

  Changes in [23.5.0](https://github.com/meejah/txtorcon/releases/tag/v23.5.0):

  * twisted.web.client.Agent instances now use the same HTTPS policy by default as twisted.web.client.Agent. It is possible to override this policy with the tls_context_factory= argument, the equivalent to Agent's contextFactory= (Thanks to Itamar Turner-Trauring)
  * Added support + testing for Python 3.11.
  * No more ipaddress dependency

  Changes in [23.11.0](https://github.com/meejah/txtorcon/releases/tag/v23.11.0):

   * Fix test-failures on Python 3.12
   * Particular GETINFO hanging (meejah/txtorcon#389) (ultra-long lines over 16KiB caused problems in the protocol)
   * Use built-in `mock` only (https://github.com/jelly)
   * Remove `incremental` (https://github.com/gdrosos)

  Basically, not much changes, but fixed bug, dropped dependencies and better support for Python 3.11 and 3.12 is good enough reason to merge for me.

Top commit has no ACKs.

Tree-SHA512: 0379dfd7303f3d2f5567fddda75f4d06af1fb56c0499245745842ba82b5623d49324e4c36e7e759b50becb22874a32282c115f6c5a2c5c18979acc4b096f7d18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants