-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'no-blockchain' blockchain_source option. #478
Conversation
This is intended primarily to support running the ob-watcher.py script from any environment that has no blockchain access. It could be used in debug and possibly recovery scenarios, but this is explicitly unsupported (see comments in config).
56a0843
to
931a5c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, ACK 931a5c8 (tested with no Bitcoin Core running)
Could this also work for exporting individual private keys using the -H option of wallet-tool ? Edit: By my brief reading of the code it might work for methods in the |
Yeah we could think this through a bit, sorry I was being a bit lazy :) Could be used for noscan methods right? I think where it starts to get tricky is when we want to support "loading" a wallet without any usage information. There starts to be a danger of misleading users. |
Btw was also thinking about going further and supporting display of some information on the GUI with this, by adding some kind of connectivity icon in the status bar that would show clearly a 'disconnected' state, but it's a significantly more complicated thing. Perhaps in future. (If we did this it could make some sense to have a connectivity heartbeat loop in the wallet service or blockchain code so you could actually show if the rpc connection to Core was unavailable, also. On CLI the same function could just have the effect of an error level logging message.) |
Accidentally had kept this setting from previous testing and noticed that joinmarket-qt will fail on wallet load with error, but on console output only, no messages in GUI itself. Probably it's worth adding check there, that it will not even start with a such configuration (with an error in GUI message box).
|
Of course, not if the some partial support of this is added to the GUI, but likely it will remain in "perhaps in future" state for at least some time. :) |
Yeah this needs to have something in GUI so the user knows what happened, and corrects the setting, will do, thanks. |
8ae41b1 tests OK (error message box and quit if no-blockchain configured with Qt). |
This is intended primarily to support running the
ob-watcher.py script from any environment that has no
blockchain access.
It could be used in debug and possibly recovery scenarios,
but this is explicitly unsupported (see comments in config).