Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing full texts for some books #26

Open
smythp opened this issue Mar 23, 2018 · 2 comments
Open

Missing full texts for some books #26

smythp opened this issue Mar 23, 2018 · 2 comments
Labels
2.0 Issues for version 2.0 (complete rewrite)

Comments

@smythp
Copy link

smythp commented Mar 23, 2018

Hey, got item # 807 back as a detective novel when I query for metadata, but it returns an empty list when I request the full text.

http://corpus-db.org/api/id/807/fulltext
@JonathanReeve
Copy link
Owner

Damn. Yeah I guess there are just some missing texts. For a lot of the scripts that I used to create the DB, I just used a lazy try/except error handling that would just skip past anything that caused errors. As a results, there are lots of things missing. Hopefully I can fix this in the 2.0 rewrite. I'll slate this for 2.0.

@JonathanReeve JonathanReeve added the 2.0 Issues for version 2.0 (complete rewrite) label Mar 23, 2018
@JonathanReeve JonathanReeve changed the title Missing item(s)? Missing full texts for some books Mar 23, 2018
@smythp
Copy link
Author

smythp commented Mar 23, 2018

Sounds good! Unfortunately this means I have to put in a lot of edge case handling which is making my notebook look pretty industrial heh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.0 Issues for version 2.0 (complete rewrite)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JonathanReeve @smythp