Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to submit ISRCs to multi-medium release #16

Closed
foolip opened this issue Apr 24, 2012 · 4 comments

Comments

@foolip
Copy link

commented Apr 24, 2012

I'm trying to submit ISRCs for CD 1 of http://musicbrainz.org/release/70dfcd0a-29ed-4a5f-ab72-e2be62eadd85

$ isrcsubmit.py foolip
isrcsubmit 0.4 by JonnyJD for MusicBrainz

using python-musicbrainz2 0.7.4
using Cdrdao 1.2.3

Please input your Musicbrainz password
Password:

DiscID: PC5dKsHXfLSTtLUNUgecT68qGBI-
Tracks on Disc: 11
Artist: 陳奕迅
Release: 上五樓的快活
Tracks in Release: 15
CRITICAL: track count mismatch!
CRITICAL: There are 11 tracks on the disc,
CRITICAL: but 15 tracks on a SINGLE-disc-release.
CRITICAL: This is not supposed to happen.

Looks like an old API that doesn't understand mediums is being used?

@JonnyJD

This comment has been minimized.

Copy link
Owner

commented Apr 24, 2012

Yes, the script is still using the old API. A new version is planned. However, that shouldn't be a big problem in many cases and also not this one.

My first guess would be, that the script thinks it is a single disc release, because there is only one Disc ID given. There is no ID for the DVD.

I will probably do that offset-guessing part also in this case, later this day.

Thanks for reporting.

@ghost ghost assigned JonnyJD Apr 24, 2012

JonnyJD added a commit that referenced this issue Apr 24, 2012

handle bonus DVDs gracefully, re #16
Having a track count mismatch between the disc and the release given by
the (version 1) API with just one disc ID is a weird case.
There either is a real problem with some data tracks on a disc,
or there is another disc in this release without a disc ID.

This happens when a release with just 1 CD has an additional bonus DVD
that is also tracked in MB. DVDs don't have disc IDs.

We handle the latter case gracefully now and guess the track offset as
0.
@JonnyJD

This comment has been minimized.

Copy link
Owner

commented Apr 24, 2012

I reworked the workaround a bit.

The problem in this case is having a bonus DVD (that can't have a disc ID). The Workaround to detect multiple releases in the old API with NGS works with Disc IDs.
And it's not that the old API couldn't handle multiple disc releases. It just that the old API never got fixed for NGS ;--)

Please try if this isrcsubmit.py does what you want.
I will release a version 0.4.1.

PS:
Of course this is only a workaround and this script should use the new API. However, I didn't have time for that yet and guessing track offsets, based on DiscIDs given, works quite well for most cases (releases with 1 or 2 CDs, 1 disc ID each). Few people actually come across the part where they have to give an offset.

Progress in that direction is also affected by python-musicbrainz-ngs, especially the libdiscid support, having a stable/complete api and the question if that shouldn't be renamed to python-musicbrainz3..

@foolip

This comment has been minimized.

Copy link
Author

commented Apr 29, 2012

Yep, that works:

$ ./isrcsubmit.py foolip
isrcsubmit 0.4.1 by JonnyJD for MusicBrainz

using python-musicbrainz2 0.7.4
using Cdrdao 1.2.3

Please input your Musicbrainz password
Password:

DiscID: PC5dKsHXfLSTtLUNUgecT68qGBI-
Tracks on Disc: 11
Artist: 陳奕迅
Release: 上五樓的快活
Tracks in Release: 15

WARNING: Multi-disc-release given by web service.
See 'isrcsubmit.py -h' for help
Track count mismatch!
There are 11 tracks on the disc,
but 15 tracks
given for just one DiscID.

There might be multiple disc IDs per disc or none,
so the number of actual discs could be lower or even higher.

This is disc (ID) 1 of 1
This release probably has a bonus DVD without a discID.
Guessing track offset as 0

HKUM70900528 is already attached to track 2
HKUM70900529 is already attached to track 3
HKUM70900530 is already attached to track 4
HKUM70900560 is already attached to track 5
HKUM70900532 is already attached to track 6
HKUM70900533 is already attached to track 7
HKUM70900534 is already attached to track 8
HKUM70900535 is already attached to track 9
HKUM70900536 is already attached to track 10
HKUM70900561 is already attached to track 11

No new ISRCs could be found.

@JonnyJD

This comment has been minimized.

Copy link
Owner

commented Apr 29, 2012

Thanks. Released as 0.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.