-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to submit ISRCs to multi-medium release #16
Comments
Yes, the script is still using the old API. A new version is planned. However, that shouldn't be a big problem in many cases and also not this one. My first guess would be, that the script thinks it is a single disc release, because there is only one Disc ID given. There is no ID for the DVD. I will probably do that offset-guessing part also in this case, later this day. Thanks for reporting. |
Having a track count mismatch between the disc and the release given by the (version 1) API with just one disc ID is a weird case. There either is a real problem with some data tracks on a disc, or there is another disc in this release without a disc ID. This happens when a release with just 1 CD has an additional bonus DVD that is also tracked in MB. DVDs don't have disc IDs. We handle the latter case gracefully now and guess the track offset as 0.
I reworked the workaround a bit. The problem in this case is having a bonus DVD (that can't have a disc ID). The Workaround to detect multiple releases in the old API with NGS works with Disc IDs. Please try if this isrcsubmit.py does what you want. PS: Progress in that direction is also affected by python-musicbrainz-ngs, especially the libdiscid support, having a stable/complete api and the question if that shouldn't be renamed to python-musicbrainz3.. |
Yep, that works: $ ./isrcsubmit.py foolip using python-musicbrainz2 0.7.4 Please input your Musicbrainz password DiscID: PC5dKsHXfLSTtLUNUgecT68qGBI- WARNING: Multi-disc-release given by web service. There might be multiple disc IDs per disc or none, This is disc (ID) 1 of 1 HKUM70900528 is already attached to track 2 No new ISRCs could be found. |
Thanks. Released as 0.4.1. |
I'm trying to submit ISRCs for CD 1 of http://musicbrainz.org/release/70dfcd0a-29ed-4a5f-ab72-e2be62eadd85
$ isrcsubmit.py foolip
isrcsubmit 0.4 by JonnyJD for MusicBrainz
using python-musicbrainz2 0.7.4
using Cdrdao 1.2.3
Please input your Musicbrainz password
Password:
DiscID: PC5dKsHXfLSTtLUNUgecT68qGBI-
Tracks on Disc: 11
Artist: 陳奕迅
Release: 上五樓的快活
Tracks in Release: 15
CRITICAL: track count mismatch!
CRITICAL: There are 11 tracks on the disc,
CRITICAL: but 15 tracks on a SINGLE-disc-release.
CRITICAL: This is not supposed to happen.
Looks like an old API that doesn't understand mediums is being used?
The text was updated successfully, but these errors were encountered: