Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test CrontabScheduleTests.DontLoopIndefinitely fails, TimeCron method contains error #2

Closed
GoogleCodeExporter opened this issue Nov 6, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Build the solution
2. Run unit test without attaching debugger


What is the expected output? What do you see instead?
Expected: green result
Instead: DontLoopIndefinitely is red

What version of the product are you using? On what operating system?
NCrontab 0.2


Please provide any additional information below.
Body of TimeCron should be changed:

if (worker.Join(!Debugger.IsAttached ? (int)limit.TotalMilliseconds :
Timeout.Infinite))

instead of

if (worker.Join(!Debugger.IsAttached ? limit.Milliseconds : Timeout.Infinite))

=> use the TotalMilliseconds property of a TimeSpan .

Original issue reported on code.google.com by jan.verh...@gmail.com on 25 Nov 2008 at 9:07

@GoogleCodeExporter
Copy link
Author

Original comment by azizatif on 3 Feb 2009 at 1:52

  • Changed title: Unit test CrontabScheduleTests.DontLoopIndefinitely fails, TimeCron method contains error
  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

Original comment by azizatif on 3 Feb 2009 at 1:52

  • Changed state: Started
  • Added labels: Component-Tests

@GoogleCodeExporter
Copy link
Author

Fixed in r19. Thanks.

Original comment by azizatif on 3 Feb 2009 at 1:54

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Issue 4 has been merged into this issue.

Original comment by azizatif on 12 Aug 2010 at 6:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant