Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vite 5 support #126

Closed
harry-73 opened this issue Feb 23, 2024 · 4 comments
Closed

vite 5 support #126

harry-73 opened this issue Feb 23, 2024 · 4 comments

Comments

@harry-73
Copy link

Hi,

Is there plan to support vite 5?

Thanks.

@JorgenVatle
Copy link
Owner

There is! I don't believe the plugin is incompatible with Vite v5. We're just waiting on Meteor v3, as Vite v5 dropped support for Node.js 14 - which is the version Meteor v2 uses internally.

If there is a need for Vite v5 for users on Meteor v2, there are certainly ways to get around this, as I assume most people will have a newer version of Node.js already installed that we can use instead when firing up Vite from Meteor. But I've opted not to put much time into that as I don't think the complexity of managing two Node.js installs for your environment makes the upgrade worthwhile.

But again, I'm open to add support if there is a real need. I'd love to hear some use cases. 🙌

@JorgenVatle JorgenVatle pinned this issue Feb 24, 2024
@harry-73
Copy link
Author

In fact, I use the package vite-plugin-vuetify and it has as peer dependencies vite >=5:

"peerDependencies": {
        "vite": ">=5",
        "vue": "^3.0.0",
        "vuetify": "^3.0.0"
      }

So I have some error running npm.

But at least everything to work.

@JorgenVatle
Copy link
Owner

JorgenVatle commented Feb 24, 2024

Yeah, most plugins have recently upped their major version to match the new Vite release. Usually there aren't any major changes apart from the Vite v5 version bump.

https://github.com/vuetifyjs/vuetify-loader/blob/master/packages/vite-plugin/CHANGELOG.md#-breaking-changes

The following snippet should fix those warnings for you. I'll be sure to add Vite v4 as a peer dependency for our plugin so npm won't try to install incompatible plugin versions.

meteor npm i vite-plugin-vuetify@1

@harry-73
Copy link
Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants