Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Error propagation mismatch #231

Merged
merged 1 commit into from
Feb 11, 2024
Merged

fix(core): Error propagation mismatch #231

merged 1 commit into from
Feb 11, 2024

Conversation

JoseLion
Copy link
Owner

Callbacks (Functions and Consumers) of the API that receive the actual error as a parameter need to change their generic type from ? super E to a Throwable. Because the error propagates downstream in the API, we cannot guarantee that the current error type matches the Function/Consumer parameter type. If the types mismatch, we'll get a ClassCastException instead.

@JoseLion JoseLion self-assigned this Feb 11, 2024
Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (30d6342) 100.00% compared to head (41388dd) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #231   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       122       125    +3     
===========================================
  Files              7         7           
  Lines            298       302    +4     
  Branches          10        10           
===========================================
+ Hits             298       302    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoseLion JoseLion merged commit 36eae26 into main Feb 11, 2024
7 checks passed
@JoseLion JoseLion deleted the fix/error-mismatch branch February 11, 2024 01:23
Copy link

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant