Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 - Rebuild #17

Closed
Joshua-Noakes1 opened this issue Aug 17, 2021 · 18 comments
Closed

V3 - Rebuild #17

Joshua-Noakes1 opened this issue Aug 17, 2021 · 18 comments

Comments

@Joshua-Noakes1
Copy link
Owner

I abandoned V2 in favour for a V3

@Joshua-Noakes1 Joshua-Noakes1 mentioned this issue Aug 17, 2021
@Joshua-Noakes1
Copy link
Owner Author

image
iOS top bar doesn't look if it's left alone

@Joshua-Noakes1
Copy link
Owner Author

From having a quick look sharp seems to have everything that we use in jimp, compiles on oracle cloud and runs at pretty much the same speed as on my pc so we're switching to sharp

@Joshua-Noakes1
Copy link
Owner Author

I think with using docker the install of jimp shouldnt be an issue also sharp cant make corners correctly
test

@Joshua-Noakes1
Copy link
Owner Author

jimp makes corners better
test

@Joshua-Noakes1
Copy link
Owner Author

image
Imgmin might of been the issue when saving
Left is from imgmin and right is just Jimp

@Joshua-Noakes1
Copy link
Owner Author

image-d81b104e-05fe-49f6-b463-50fe1640fae5
issue was imgmin

@Joshua-Noakes1
Copy link
Owner Author

image

@Joshua-Noakes1
Copy link
Owner Author

image-f7e4e53c-8d48-4393-b6c2-c21895692e14
taglines are too long

@Joshua-Noakes1
Copy link
Owner Author

Tweet1
tweet exists

@Joshua-Noakes1
Copy link
Owner Author

test
spotify media card

@Joshua-Noakes1
Copy link
Owner Author

image
Mobile image is small

@Joshua-Noakes1
Copy link
Owner Author

@Joshua-Noakes1
Copy link
Owner Author

/usr/src/app/node_modules/spotify-url-info/index.js:32,
        .children.filter(e => e.tagName === 'body')[0],�,
^,
,
TypeError: Cannot read property 'children' of undefined,
    at /usr/src/app/node_modules/spotify-url-info/index.js:32:9,
    at processTicksAndRejections (node:internal/process/task_queues:96:5),
    at async spotify (/usr/src/app/lib/routes/spotifyRoutes/spotify.js:35:23),

ifttt causing issues

@Joshua-Noakes1
Copy link
Owner Author

ifttt had a space in the url and that caused an issue

@Joshua-Noakes1
Copy link
Owner Author

image

@Joshua-Noakes1
Copy link
Owner Author

image
i might try and use regex to pull the time out of the ifttt time stamp because if youre playing lots of songs at once it gets delayed

@Joshua-Noakes1
Copy link
Owner Author

5f35fd2 fixes the Spotify issue

@Joshua-Noakes1
Copy link
Owner Author

Rewrite is done

Repository owner locked as resolved and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant