Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Throw an error when the user has no packages on npm #17

Open
3 tasks done
JoshuaKGoldberg opened this issue Jun 17, 2023 · 0 comments
Open
3 tasks done
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Right now, if you run npx tidelift-me-up --username "#JI*#@%OJSL" (some username that definitely doesn't exist), it does ... nothing.

$ npx tidelift-me-up --username "#JI*#@%OJSL"
$ 

That could be confusing for folks who mistype their username. Let's have the package throw new Error when the user has no packages published to npm.

Additional Info

Right now, we fetch user npm packages with the npm-user-packages package here:

const userPackages = (await npmUserPackages(username)).filter(
createUserPackagesFilter({ ownership, since: new Date(since), username })
);

@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Development

No branches or pull requests

1 participant