-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Delivers #158791587] Edit User API Endpoint #33
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 248
💛 - Coveralls |
This was referenced Jul 6, 2018
Repository owner
deleted a comment
Jul 6, 2018
Repository owner
deleted a comment
Jul 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds edit user endpoint to the API
Description of Task to be completed
A user should be able to edit their details
PUT
/api/v2/users
Tasks achieved in this PR
/api/v2/users
How should one test this endpoint?
git clone https://github.com/JoshuaOndieki/ridemyway-api.git
git checkout ft-edit-user-158791587
nosetests
to see the tests pass. Alternatively, runpytest
How can you help?
Review my work and let me know any semantic, technical or syntax/standards errors I may have.
I will greatly appreciate any feature/change suggestions too 😃
Resources & Libs
This Pivotal Tracker board was used to plan and manage the tasks.
Relevant PIvotal Tracker Stories?
#158791587