Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Delivers #158791587] Edit User API Endpoint #33

Merged
merged 16 commits into from
Jul 7, 2018

Conversation

JoshuaOndieki
Copy link
Owner

What does this PR do?
Adds edit user endpoint to the API

Description of Task to be completed
A user should be able to edit their details

PUT /api/v2/users

Tasks achieved in this PR

  • PUT /api/v2/users

How should one test this endpoint?

  • Clone this repo using git clone https://github.com/JoshuaOndieki/ridemyway-api.git
  • Check the ReadMe for instructions on setting up the project.
  • git checkout ft-edit-user-158791587
  • Run nosetests to see the tests pass. Alternatively, run pytest

How can you help?
Review my work and let me know any semantic, technical or syntax/standards errors I may have.
I will greatly appreciate any feature/change suggestions too 😃

Resources & Libs
This Pivotal Tracker board was used to plan and manage the tasks.

Relevant PIvotal Tracker Stories?
#158791587

@coveralls
Copy link

coveralls commented Jul 6, 2018

Pull Request Test Coverage Report for Build 248

  • 110 of 127 (86.61%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.5%) to 94.199%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ridemyway/tests/tests_v2/test_user/test_edit_user.py 38 39 97.44%
ridemyway/api/v2/resources.py 17 18 94.44%
ridemyway/utils/db_queries.py 8 10 80.0%
ridemyway/utils/errors.py 9 14 64.29%
ridemyway/api/v2/controllers/user.py 25 33 75.76%
Totals Coverage Status
Change from base Build 246: -1.5%
Covered Lines: 747
Relevant Lines: 793

💛 - Coveralls

Repository owner deleted a comment Jul 6, 2018
Repository owner deleted a comment Jul 7, 2018
@JoshuaOndieki JoshuaOndieki merged commit ef5db1b into develop Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants