-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Count normal transfers as total channel revenue #330
Comments
I assume that the fact that someone can boost their own total revenue by just transferring money to the channel rewards account and claim it in withdrawal over and over again is not a problem? Afterwards, one can just create a token and be a top earner although this person might not even generate any revenue. |
While this is indeed possible to do, there are also some highly creative uses of the CRT function being explored currently that would stand to benefit from this functionality:
So while the attack or manipulation you mention may be tried by some I think we will have to deal with it in the design of Atlas/Gleev (for instance: by showing the amount actually withdrawn from revenue splits) or some other ways In any case, I believe people can just count transfers into the revenue account as "revenue" by using the extrinsic which attaches a remark to the TX. So it is trivial for bad actors to do this (although I am not 100% certain whether this is restricted to only the YPP account). It is also possible for people to do wash or circular trading of NFTs and artificially inflate their channels revenue. |
Just an update on this @bedeho @ikprk There are now 2 CRTs for which this edge case applies:
The revenue for both of these isn't registered and therefore they do not/will not show in the top CRTs and in other areas of the CRT marketplace. So while these may still seem like edge cases, I feel it is important that this issue gets addressed because these are either already some of the highest revenue CRTs or will be and although edge cases can inject some much needed excitement/interest into the current CRT offerings. |
Joystream/atlas#6271
The text was updated successfully, but these errors were encountered: