Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge nara into dev #4799

Merged
merged 10 commits into from
Mar 13, 2024
Merged

Merge nara into dev #4799

merged 10 commits into from
Mar 13, 2024

Conversation

kdembler
Copy link
Member

No description provided.

thesan and others added 6 commits November 6, 2023 14:10
* Update `@joystream/types`

* Update `@joystream/types` to `4.1.0`
* schema

* Create Freeze Pallet Proposal

* update pallet frozen status
storybook test

* type check

* recommended fix

* required changes

* required changes

* required changes

* required changes

* required changes

* required changes

* Minor formatting

---------

Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
* schema

* Create Freeze Pallet Proposal

* update pallet frozen status
storybook test

* type check

* Preview proposal and storybook

* linting

* required changes

* required changes
* schema

* Create Freeze Pallet Proposal

* update pallet frozen status
storybook test

* type check

* Preview proposal and storybook

* linting

* required changes

* required changes

* follow up PR

* required changes

* required changes

* required changes
* Fix the creator token state switch input value

* Fix the execution requirement alert

* Match the design

* Improve the tests
Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Mar 13, 2024 1:01pm
pioneer-2 ✅ Ready (Inspect) Visit Preview Mar 13, 2024 1:01pm
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Mar 13, 2024 1:01pm

The result of `palletFrozen().toJSON()` is a `boolean` primitive however `createType('bool').toJSON()` returns a `Boolean` object (this is why the test was failing. To be safer lets work with a js boolean instead of the polkdaot.js type.
@thesan thesan merged commit f59caa4 into dev Mar 13, 2024
8 checks passed
@thesan thesan deleted the nara branch March 13, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants