This repository has been archived by the owner on Jul 30, 2020. It is now read-only.
Council fixes #12
Merged
Council fixes #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siman
reviewed
Feb 7, 2019
| @@ -7,32 +7,20 @@ use runtime_primitives::traits::{SimpleArithmetic}; | |||
| pub struct Stake<Balance> | |||
| where Balance: Copy + SimpleArithmetic, | |||
| { | |||
| pub refundable: Balance, | |||
| pub new: Balance, | |||
There was a problem hiding this comment.
Although I like the word new in this case, it could be a little bit confusing when using Stake struct on the JavaScript side. I remember we discussed extra as well.
| @@ -7,32 +7,20 @@ use runtime_primitives::traits::{SimpleArithmetic}; | |||
| pub struct Stake<Balance> | |||
| where Balance: Copy + SimpleArithmetic, | |||
| { | |||
| pub refundable: Balance, | |||
| pub new: Balance, | |||
| pub transferred: Balance, | |||
There was a problem hiding this comment.
What about renaming of transferred to reused? I remember you used this word to describe the purpose of this field of stake struct.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.