fix(1358): add trailing zero when mask="separator.1" and leadZero="true" #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, no trailing zero is added when mask="separator.1" and leadZero="true" and input loses focus. This change adds the trailing zero in that case.
NepipenkoIgor
added a commit
that referenced
this pull request
May 8, 2024
* feat(ref: no-ref): add setup hooks, remove karma (#1340) * feat(ref: no-ref): add setup hooks, remove carma * feat(ref: no-ref): remove environment * feat(ref: no-ref): fix warnings in console * feat(ref: no-ref): remove cypress from lib folder * feat(ref: no-ref): add text to readme * build(deps-dev): bump undici from 5.28.3 to 5.28.4 (#1343) Bumps [undici](https://github.com/nodejs/undici) from 5.28.3 to 5.28.4. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.28.3...v5.28.4) --- updated-dependencies: - dependency-name: undici dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump tar and npm (#1346) Bumps [tar](https://github.com/isaacs/node-tar) and [npm](https://github.com/npm/cli). These dependencies needed to be updated together. Updates `tar` from 6.1.14 to 6.2.1 - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.1.14...v6.2.1) Updates `npm` from 10.5.0 to 10.5.2 - [Release notes](https://github.com/npm/cli/releases) - [Changelog](https://github.com/npm/cli/blob/latest/CHANGELOG.md) - [Commits](npm/cli@v10.5.0...v10.5.2) --- updated-dependencies: - dependency-name: tar dependency-type: indirect - dependency-name: npm dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump undici and @angular-devkit/build-angular (#1351) Bumps [undici](https://github.com/nodejs/undici) to 6.11.1 and updates ancestor dependency [@angular-devkit/build-angular](https://github.com/angular/angular-cli). These dependencies need to be updated together. Updates `undici` from 6.7.1 to 6.11.1 - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v6.7.1...v6.11.1) Updates `@angular-devkit/build-angular` from 17.3.0 to 17.3.4 - [Release notes](https://github.com/angular/angular-cli/releases) - [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md) - [Commits](angular/angular-cli@17.3.0...17.3.4) --- updated-dependencies: - dependency-name: undici dependency-type: indirect - dependency-name: "@angular-devkit/build-angular" dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(no-ref): update deps (#1353) * feat(no-ref): update deps * feat(no-ref): update deps v1 * fix(1358): add trailing zero when mask="separator.1" and leadZero="true" (#1359) Currently, no trailing zero is added when mask="separator.1" and leadZero="true" and input loses focus. This change adds the trailing zero in that case. * feat(no-ref): up deps (#1362) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Andrii Kamaldinov <129040945+andriikamaldinov1@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nathaniel Buck <nathaniel.buck@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, no trailing zero is added when mask="separator.1" and leadZero="true" and input loses focus. This change adds the trailing zero in that case.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When
mask="separator.1"andleadZero="true", the input's value doesn't change when there is no decimal and the input loses focus. So, if1is entered in this case, the value remains1but the desired result is that the value would be changed to1.0.Issue Number: #1358
What is the new behavior?
When
1is entered and the input loses focus, the value is replaced with1.0Does this PR introduce a breaking change?