-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLJ 0.17, ScientificTypes 3.0 update #174
Comments
@OkonSamuel Note that I have added two points to the first list. |
Had a quick first go at this but am failing to precompile 0.17 on 1.7.1 which is not ideal. will do a bit of digging but in the meantime if someone has an idea .. EDIT: fixed |
To better understand the pipeline stuff, could I get guidance on how to update this?
|
This would just be pipe = (X -> coerce(X, :age=>Continuous)) |>
OneHotEncoder() |>
KNNRegressor(K=3)
model = TransformedTargetModel(
pipe,
target = UnivariateStandardizer
) |
I'd probably invert the composition here - first wrap KNN in a target transformer and then insert into the pipeline. See https://github.com/ablaom/MLJTutorial.jl/tree/dev/notebooks/03_pipelines which is already revised for examples. |
Ideally if you guys could suggest copy-pastable replacements in the PR for the places where this appears:
(beyond just the pipeline syntax there's usually a couple of lines afterwards which query elements in the pipeline which have to be updated as well). |
I've merged the PR as it was causing issues with the deployment, I'll let you guys adjust the |
all done, thanks @OkonSamuel for the help and fixes! |
Time to update all the tutorials once more. Breaking changes listed here.
Probably the main changes are:
EnsmbleModel(atom=...)
is nowEnsembleModel(model=...)
(breaking)@pipeline
is deprecated in favour of macro free pipelines (using|>
syntax) and the use of the new wrapperTransformedTargetModel(model=..., target=..., )
for target transformations.added If the last predicate inunpack(...)
is of the form_ -> true
, then it can be dropped (Changeunpack
to avoidcolname -> true
mystery MLJBase.jl#621)added the entire section on "arrow syntax" can be dropped, as this syntax has been usurped by pipelinesTodo:
cc @OkonSamuel
The text was updated successfully, but these errors were encountered: