Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to reflect recent BetaML reorganisation #1091

Merged
merged 6 commits into from
Jan 29, 2024
Merged

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Jan 28, 2024

#1090 #1089 No new release.

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (51ed76e) 57.89% compared to head (24d5bf2) 57.89%.
Report is 23 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1091   +/-   ##
=======================================
  Coverage   57.89%   57.89%           
=======================================
  Files           2        2           
  Lines          38       38           
=======================================
  Hits           22       22           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ablaom
Copy link
Member Author

ablaom commented Jan 28, 2024

Failure of integration tests needs:

@ablaom
Copy link
Member Author

ablaom commented Jan 28, 2024

to fix doc failure we need:

  • add missing model descriptor for PerceptronClassifier (BetaML): self-assigned
ERROR: LoadError: The following keys are missing from /docs/ModelDescriptors.toml: ["PerceptronClassifier_BetaML"]. 
[18](https://github.com/alan-turing-institute/MLJ.jl/actions/runs/7687809013/job/20948276721?pr=1091#step:6:19)
Stacktrace:
[19](https://github.com/alan-turing-institute/MLJ.jl/actions/runs/7687809013/job/20948276721?pr=1091#step:6:20)
 [1] error(s::String)
[20](https://github.com/alan-turing-institute/MLJ.jl/actions/runs/7687809013/job/20948276721?pr=1091#step:6:21)
   @ Base ./error.jl:35
[21](https://github.com/alan-turing-institute/MLJ.jl/actions/runs/7687809013/job/20948276721?pr=1091#step:6:22)
 [2] top-level scope
[22](https://github.com/alan-turing-institute/MLJ.jl/actions/runs/7687809013/job/20948276721?pr=1091#step:6:23)
   @ ~/work/MLJ.jl/MLJ.jl/docs/make.jl:33
[23](https://github.com/alan-turing-institute/MLJ.jl/actions/runs/7687809013/job/20948276721?pr=1091#step:6:24)
in expression starting at /home/runner/work/MLJ.jl/MLJ.jl/docs/make.jl:33
[24](https://github.com/alan-turing-institute/MLJ.jl/actions/runs/7687809013/job/20948276721?pr=1091#step:6:25)
ERROR: LoadError: failed process: Process(`julia --project=docs docs/make.jl`, ProcessExited(1)) [1]

cc @sylvaticus

@ablaom ablaom merged commit 48ffbd3 into master Jan 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants