Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Compat from Project.toml #160

Closed
ablaom opened this issue Dec 11, 2019 · 1 comment
Closed

Remove Compat from Project.toml #160

ablaom opened this issue Dec 11, 2019 · 1 comment

Comments

@ablaom
Copy link
Member

ablaom commented Dec 11, 2019

In PR #159 Compat was added to the Project with [compat] Compat="0.2". When we figure out why the recent update of Compat to 3.0 is breaking testing of LIBSVM and NaiveBayes we should get rid of Compat.

See also JuliaML/LIBSVM.jl#48 and #155
@ablaom
Copy link
Member Author

ablaom commented Mar 24, 2020

I have revisited this issue and it appears that we can now remove Compat as a dependency (to remove the cap on its version) after this pending [compat] update in GLM.

@ablaom ablaom mentioned this issue Mar 24, 2020
Merged
ablaom added a commit that referenced this issue Mar 24, 2020
@ablaom
rm Compat.jl as explicit dependency #160
ef3236f
@ablaom ablaom mentioned this issue Mar 24, 2020
Merged
@ablaom ablaom closed this as completed Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ablaom