Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to allow Compat = 3.0 in REQUIRE or, better, upgrade to Julia 1.0 #48

Closed
ablaom opened this issue Dec 9, 2019 · 7 comments
Closed

Comments

@ablaom
Copy link
Contributor

ablaom commented Dec 9, 2019

MLJ currently provides a wrapper for the LIBSVM.jl models. For reasons I don't yet understand (JuliaAI/MLJModels.jl#155) it appears a recent update of Compat to 3.0 is going to break this wrapper.

I wonder if there is any chance someone is interested in giving this package a little love. If not, MLJ may have discontinue support.

It is worth noting that MLJ also wraps the ScikitLearn SVM models (which, in turn, wrap the same C libraries wrapped here, I believe) so maybe this is not a great loss. Nevertheless, it would be nicer to skip the python layer.

@ValdarT @DilumAluthge @simonster @mpastell

@DilumAluthge
Copy link
Contributor

@ablaom It does seem like this package is unmaintained.

Would you be interested in cloning this package, renaming it LIBSVM2, hosting it under Alan Turing Institute, and registering it?

I think it is easier to keep a package maintained when it is owned by a GitHub organization (instead of a personal user account).

@ablaom
Copy link
Contributor Author

ablaom commented Dec 9, 2019

@DilumAluthge Thanks for that quick response.

Would you be interested in cloning this package, renaming it LIBSVM2, hosting it under Alan Turing Institute, and registering it?

Well, not really, as we don't presently have the resources to adopt external packages. And I don't see that we need to clutter General if the authors are happy to accept PRs from a willing volunteer (hint, hint 😄 )

@ValdarT wrote the MLJ wrap. Perhaps he is inerested in volunteering?

@DilumAluthge
Copy link
Contributor

it appears a recent update of Compat to 3.0 is going to break this wrapper.

I actually think that we can remove Compat as a dependency of this package.

@DilumAluthge
Copy link
Contributor

if the authors are happy to accept PRs from a willing volunteer

The issue unfortunately is that the author has not been responsive, see e.g. #47.

Besides @mpastell, I’m not sure who else has push access to this repo.

@DilumAluthge
Copy link
Contributor

@ablaom LIBSVM now has the following:

[compat]
Compat = "2, 3"

@mpastell
Copy link
Contributor

Sorry for taking so long with approving the pull request and thanks for letting me know via email. I would be happy to transfer the repo to an organisation to make maintenance easier. I do hope to find some more time to work on open source again next year...

@aviks
Copy link
Contributor

aviks commented Aug 21, 2020

A new version of LibSVM has just been tagged.

@aviks aviks closed this as completed Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants