-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes [failing due to LIBSVM compat bound] #155
Conversation
tlienart
commented
Dec 5, 2019
•
edited
Loading
edited
- addresses Update RandomForestRegressor input_scitype #154 (randomforest* input scitype) + a fix for LinearRegressor in GLM
Not passing due to shitty compat bounds on LIBSVM... I don't think we can put explicit requirements on optional packages...
|
@@ -187,7 +187,7 @@ metadata_pkg.((LinearRegressor, LinearBinaryClassifier, LinearCountRegressor), | |||
|
|||
metadata_model(LinearRegressor, | |||
input=MLJBase.Table(MLJBase.Continuous), | |||
output=AbstractVector{MLJBase.Continuous}, | |||
target=AbstractVector{MLJBase.Continuous}, | |||
weights=false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
I don't understand this at all. LIBSVM.jl has no Project file, only a REQUIRE file. According to the old julia documentation the versions specified there are just lower bounds. Since it specifies "Compat 0.41.0" there should be no prohibition on Compat 3.0, right? Indeed this is confirmed by previous builds of MLJModels, where testing (of LIBSVM wrapper) carried on happily with Compat 2.2. But, if in a new environment I |
add Compat so as to pin it to version 2.0
Just restarting the build after merging #159 |