Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes [failing due to LIBSVM compat bound] #155

Merged
merged 9 commits into from
Dec 11, 2019
Merged

Small fixes [failing due to LIBSVM compat bound] #155

merged 9 commits into from
Dec 11, 2019

Conversation

tlienart
Copy link
Collaborator

@tlienart tlienart commented Dec 5, 2019

@tlienart
Copy link
Collaborator Author

tlienart commented Dec 6, 2019

Not passing due to shitty compat bounds on LIBSVM... I don't think we can put explicit requirements on optional packages...

ERROR: Unsatisfiable requirements detected for package LIBSVM [b1bec4e5]:
 LIBSVM [b1bec4e5] log:
 ├─possible versions are: [0.2.0, 0.3.0-0.3.1] or uninstalled
 ├─restricted to versions * by an explicit requirement, leaving only versions [0.2.0, 0.3.0-0.3.1]
 └─restricted by compatibility requirements with Compat [34da2185] to versions: uninstalled — no versions left
   └─Compat [34da2185] log:
     ├─possible versions are: [1.0.0-1.0.1, 1.1.0, 1.2.0, 1.3.0, 1.4.0, 1.5.0-1.5.1, 2.0.0, 2.1.0, 2.2.0, 3.0.0] or uninstalled
     └─restricted to versions 3.0.0 by an explicit requirement, leaving only versions 3.0.0

@tlienart tlienart changed the title Small fixes Small fixes [failing due to LIBSVM compat bound] Dec 6, 2019
@@ -187,7 +187,7 @@ metadata_pkg.((LinearRegressor, LinearBinaryClassifier, LinearCountRegressor),

metadata_model(LinearRegressor,
input=MLJBase.Table(MLJBase.Continuous),
output=AbstractVector{MLJBase.Continuous},
target=AbstractVector{MLJBase.Continuous},
weights=false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ablaom
Copy link
Member

ablaom commented Dec 9, 2019

I don't understand this at all.

LIBSVM.jl has no Project file, only a REQUIRE file. According to the old julia documentation the versions specified there are just lower bounds. Since it specifies "Compat 0.41.0" there should be no prohibition on Compat 3.0, right? Indeed this is confirmed by previous builds of MLJModels, where testing (of LIBSVM wrapper) carried on happily with Compat 2.2. But, if in a new environment I add MLJModels (which puts Compat 3.0 in the manifest) then doing add LIBSVM forces Compat to drop from 3.0 to 2.2. Why?

@ablaom
Copy link
Member

ablaom commented Dec 11, 2019

Just restarting the build after merging #159

@ablaom ablaom merged commit 207c146 into dev Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants