Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FeatureSelector is still exported #562

Closed
adwasser opened this issue Jun 18, 2024 · 1 comment · Fixed by #563
Closed

FeatureSelector is still exported #562

adwasser opened this issue Jun 18, 2024 · 1 comment · Fixed by #563

Comments

@adwasser
Copy link

It looks like the FeatureSelector transformation was moved to a different package in this PR:

#558

But the symbol is still exported

MLJModels.jl/src/MLJModels.jl

Line 46 in 320a29c

export FeatureSelector, UnivariateDiscretizer,

which leads to a confusing user error:

UndefVarError: `FeatureSelector` not defined
@ablaom
Copy link
Member

ablaom commented Jun 18, 2024

Good catch, thanks!

@ablaom ablaom mentioned this issue Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove export FeatureSelector, as moved to FeatureSelection.jl JuliaAI/MLJModels.jl
2 participants
@adwasser @ablaom