-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correlated Generators #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I posted about the vector of vector issues here: https://discourse.julialang.org/t/inverting-default-collect-behavior-when-iterator-returns-an-array/85409 |
Codecov Report
@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 90.16% 94.23% +4.06%
==========================================
Files 4 4
Lines 61 104 +43
==========================================
+ Hits 55 98 +43
Misses 6 6
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
closes #17
cc @kasperrisager
Some disussion/todos:
collect(c)
returns a vector of vectors:julia> collect(c) 2-element Vector{Vector{Float64}}: [87.58135277304397, 74.84820358945774, 68.56323172218646, 57.30284156605987, 58.01804063220005, 70.50583190735524, 67.62514257297967, 67.75331112863375, 74.65392532963543, 64.16076510394042 … 29.363724347621254, 39.05933584030768, 44.259288501108955, 30.193440520663124, 35.12786141576387, 32.4511890981983, 33.791351345428474, 36.62555404546912, 41.56345911563408, 37.00931733615785] [94.43341734287529, 82.88074095422284, 76.91159150462514, 72.64687376383395, 67.09645675465482, 70.74338844031544, 69.82729451232233, 64.10372892726669, 73.7458039859808, 65.07849904945566 … 27.412784359429537, 30.282329238312855, 29.048030126437794, 21.385593116622168, 27.28257459517675, 23.8838298202843, 23.561602356185862, 26.207618041390134, 29.221929707995933, 26.89015829202149]
BlackScholesMerton
currently, but could be extended to others pretty easily as long as the following are true (I'm not sure):