-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cat operations #25
Comments
Makes sense. Concatenating existing axes can also check to make sure that the axes are consistent, which I think is very nice feature, too. I'm not sure how you'd specify a new dimension's axis, but the default constructor simply uses |
Good idea to just use the existing default axis generation. I'll see if I can get some work on this done next week. Concatenating range-labelled axes might be tricky... should one be able to append labels |
We already error on indexing and other constructions that'd create an AxisArray with an un-sorted dimensional axis, so erroring for un-ordered axes here makes sense. For discontinuities and changing step sizes, I think I'd either always error or always use a PiecewiseIncreasingRange. I don't do much concatenation that extends axes like this in my own work, so I don't have a good sense if the extra flexibility is worth the performance tradeoff. |
It would be great to have AxisArray-specific concatenation operations - it would seem fairly straightforward to implement for concatenating on existing dimensions, but operating on higher (not-yet-existing) dimensions might need a bit more consideration regarding how to create the new axes. Or maybe one would just be required to supply an appropriate
Axis
?The text was updated successfully, but these errors were encountered: