Fix deprecation warning #51
Conversation
On Julia 1.7.2 with `--depwarn=error` this expression `Vararg{<:AbstractArray}` causes the error
```julia
ERROR: Wrapping `Vararg` directly in UnionAll is deprecated (wrap the tuple instead).
Stacktrace:
[1] UnionAll(v::TypeVar, t::Any)
@ Core ./boot.jl:255
[2] top-level scope
@ REPL[25]:1
```
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 84.55% 85.15% +0.60%
==========================================
Files 1 1
Lines 123 128 +5
==========================================
+ Hits 104 109 +5
Misses 19 19
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This is causing issues for HybridSystems as well: blegat/HybridSystems.jl#53 |
|
Bump. Pinging @timholy @johnnychen94 |
|
Rerunning tests... |
|
I opened another issue recently #56 reporting this warning. It would be great if someone could merge this. ping @timholy @johnnychen94 |
|
Superseded by #57 Can someone please review and merge that PR? |
|
"Superseded" is an interesting term since that PR is identical to this one, hard to tell how that's any better. |
Didn't check the contents of this one, but just meant that there was a more recent PR opened with a fix. Since this one here has failing tests, I assumed that is was out of date. In any case, it would be super nice if someone with write access could merge this and release a patch 🙏🏽 |
|
I'll close and reopen to rerun the tests, I can't see the logs of the failures anymore as they are too old. |
|
I fixed the failures (locally), thanks for the PR! If this passes tests I will merge. |
|
(Weird. It looks like the date on my WSL instance does not match that of the underlying Windows machine.) |
|
The test failure is #43 (comment). That's clearly worthy of a separate PR, so I'll merge this. |
On Julia 1.7.2 with
--depwarn=errorthis expressionVararg{<:AbstractArray}causes the error