getindex(FITS, String) does not work

[aplavin]

In version 0.16 this getindex method stopped working (works in 0.15):

FITSIO.jl/src/fits.jl

Line 111 in ac1e773

function getindex(f::FITS, name::AbstractString, ver::Int=0)

It gives the following stacktrace:

  UndefVarError: fits_movnam_hdu not defined
  Stacktrace:
   [1] getindex(::FITSIO.FITS, ::String, ::Int64) at /home/runner/.julia/packages/FITSIO/KYCVW/src/fits.jl:113
   [2] getindex at /home/runner/.julia/packages/FITSIO/KYCVW/src/fits.jl:112 [inlined]

The fits_movnam_hdu function is indeed used here:

FITSIO.jl/src/fits.jl

Line 113 in ac1e773

fits_movnam_hdu(f.fitsfile, name, ver)

But I cannot find it defined anywhere in the FITSIO.jl repo. Was it just removed at some point? Everything is fine with version 0.15.

[giordano]

Was it just removed at some point?

It was moved to CFITSIO.jl: https://github.com/JuliaAstro/CFITSIO.jl/blob/9a1acf6c9ee278849a929d549c884076820a03d0/src/CFITSIO.jl#L812-L830

[aplavin]

Then I guess the reason why FITSIO.jl getindex method got broken is because fits_movnam_hdu is not imported here:
https://github.com/JuliaAstro/FITSIO.jl/blob/master/src/FITSIO.jl#L38-L73
Right?

[giordano]

Probably

[aplavin]

I created a PR #142 which imports the three functions required by this getindex method.

[giordano]

I guess we can close this issue now?