Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0 #711

Merged
merged 9 commits into from
Jul 6, 2022
Merged

Version 1.0 #711

merged 9 commits into from
Jul 6, 2022

Conversation

baggepinnen
Copy link
Member

Changes before v1.0

Closes #533

baggepinnen and others added 5 commits July 5, 2022 17:40
* Pid parameters updates (#509)

* stash

* pidparams suggestion

* pid creation update (ss) and s2f and f2s

* ss default, new filter

* remove paralleltime, inf->Inf

* update some tests

* single conversion method with param detection

* update errors

* Handle special cases

* Update error capitalization

* remove gof usage

* fix pidplots

* Fix pid creation, update stabregionpid

* Fix test

* Update docs

* Fix test pid in tf form

* Improve error for pid ss with D-part

* Update src/pid_design.jl

Co-authored-by: olof3 <olof3@users.noreply.github.com>

* stash

* new interface suggestion

* revert some code and make stuff work

* Ts=0 to Ts=nothing

* change parameter names when standard form

* kp/ki/kd -> param_p/param_i/param_d

* fix functions missing form

* fix tests

* fix errors to pass tests

* more tests

* Ts nothing

* make leadlinkcurve recipe and doplot on stabreg

* fix some docs

Co-authored-by: olof3 <olof3@users.noreply.github.com>
Co-authored-by: Fredrik Bagge Carlson <baggepinnen@gmail.com>

* fixes to pid

Co-authored-by: Albin Heimerson <albin.heimerson@control.lth.se>
Co-authored-by: olof3 <olof3@users.noreply.github.com>
@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 8/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.048 Reference New
✔️ 0.0 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.0 Reference New
❌ 0.043 Reference New
❌ 0.059 Reference New
✔️ 0.01 Reference New

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #711 (73971b2) into master (afe5131) will increase coverage by 0.78%.
The diff coverage is 86.17%.

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
+ Coverage   88.43%   89.22%   +0.78%     
==========================================
  Files          35       35              
  Lines        3624     3713      +89     
==========================================
+ Hits         3205     3313     +108     
+ Misses        419      400      -19     
Impacted Files Coverage Δ
src/ControlSystems.jl 100.00% <ø> (ø)
src/delay_systems.jl 87.27% <71.42%> (-1.62%) ⬇️
src/freqresp.jl 90.95% <75.00%> (-0.09%) ⬇️
src/pid_design.jl 81.22% <80.20%> (+2.60%) ⬆️
src/types/StateSpace.jl 92.36% <97.95%> (+1.54%) ⬆️
src/analysis.jl 89.29% <100.00%> (ø)
src/connections.jl 92.70% <100.00%> (+0.15%) ⬆️
src/matrix_comps.jl 93.26% <100.00%> (-0.03%) ⬇️
src/plotting.jl 89.18% <100.00%> (ø)
src/simplification.jl 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afe5131...73971b2. Read the comment docs.

@baggepinnen baggepinnen marked this pull request as ready for review July 6, 2022 13:49
@baggepinnen baggepinnen merged commit 9297c05 into master Jul 6, 2022
@baggepinnen baggepinnen deleted the v1 branch July 6, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return gramian or singular values from balreal
2 participants