Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return gramian or singular values from balreal #533

Closed
baggepinnen opened this issue Jun 1, 2021 · 0 comments · Fixed by #711
Closed

Return gramian or singular values from balreal #533

baggepinnen opened this issue Jun 1, 2021 · 0 comments · Fixed by #711
Labels
v1 Issues to resolve before releasing v1

Comments

@baggepinnen
Copy link
Member

@olof3 comments:

Some thoughts when looking through this. Perhaps change S to Σ in baltrunc for consistency. It seems like it would slightly simplify the code if just Σ was returned, rather than diagm(Σ). An other good reason is for consistency with svd/eigen.
@baggepinnen baggepinnen mentioned this issue Jun 1, 2021
Merged
@baggepinnen baggepinnen added the v1 Issues to resolve before releasing v1 label Oct 21, 2021
@baggepinnen baggepinnen mentioned this issue Jul 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v1 Issues to resolve before releasing v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version 1.0 JuliaControl/ControlSystems.jl
1 participant
@baggepinnen