Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.4 only supported. #43

Merged
merged 3 commits into from
Jul 26, 2016
Merged

0.4 only supported. #43

merged 3 commits into from
Jul 26, 2016

Conversation

PallHaraldsson
Copy link
Contributor

Say "(old version supports 0.3)", or nobody cares by now?

Where is DBAPI branch? Link to it not "DBAPI"?
[skip ci]

Say "(old version supports 0.3)", or nobody cares by now?

Where is DBAPI branch? Link to it not "DBAPI"?
[skip ci]
@iamed2
Copy link
Contributor

iamed2 commented Jul 25, 2016

"dbapi branch" refers to the dbapi git branch of this repository.

@PallHaraldsson
Copy link
Contributor Author

@iamed2 right, dbapi branch (that I just can't locate), but the dbapi link should also be appropriate/harmless?

Anyway, I also changed 0.3 -> 0.4, so ok to merge this?

@PallHaraldsson
Copy link
Contributor Author

PallHaraldsson commented Jul 26, 2016

Just a though, dbapi must be different from dbi, and with changes then PostgreSQL will be "dbi protocol"-incompatible?

Is there a way to be compatible with both? Say the newer and make dbi wrapper for dbapi? Or just a dbapi wrapper for dbi end then no changes needed here? Might not matter is dbi is just old and nobody will need in the future..

@iamed2
Copy link
Contributor

iamed2 commented Jul 26, 2016

Yeah the plan was to replace DBI as no one else appears to be using it and previous advocates are no longer active.

@iamed2
Copy link
Contributor

iamed2 commented Jul 26, 2016

The DBAPI branch name is lowercase ("dbapi") so if you change the casing back I can merge.

I thought the link would be implicit, was an error of mine, but leave as is, maybe better to have it - with DBAPI, there, upper case.

[skip ci]
[skip ci]
@iamed2 iamed2 merged commit a29b45f into JuliaDatabases:master Jul 26, 2016
@PallHaraldsson PallHaraldsson deleted the patch-1 branch July 26, 2016 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants