Add TimeZones dependency for auto-converting Timestamp #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements #17. We now convert all Timestamp objects to ZonedDateTime via auto-conversion (can be turned off by `convert=false`). The one piece of awkwardness here is that it is currently assumed that with a `Vector{ZonedDateTime}`, it is assumed that each element will have the same timezone. Probably ok in practice, but frankly it'd be nicer if there was a `ZonedDateTime` type that could be parameterized by the timezone itself so that could be enforced via type parameter.
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
==========================================
+ Coverage 83.29% 83.38% +0.08%
==========================================
Files 23 23
Lines 2640 2642 +2
==========================================
+ Hits 2199 2203 +4
+ Misses 441 439 -2
Continue to review full report at Codecov.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #17. We now convert all Timestamp objects to ZonedDateTime
via auto-conversion (can be turned off by
convert=false). The onepiece of awkwardness here is that it is currently assumed that with a
Vector{ZonedDateTime}, it is assumed that each element will have thesame timezone. Probably ok in practice, but frankly it'd be nicer if
there was a
ZonedDateTimetype that could be parameterized by thetimezone itself so that could be enforced via type parameter.
Also fixes #48. cc: @oxinabox, @kcajf, @omus