Restore old == using three-valued logic, separate from isequal() #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with null == null returning null in the next Nulls release, but does not depend on it. This was actually the old behavior when using DataArrays.
1 similar comment
quinnj
approved these changes
Sep 30, 2017
cjprybol
approved these changes
Sep 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with
null == nullreturningnullin the next Nulls release (JuliaData/Missings.jl#33), but does not depend on it. This was actually the old behavior when using DataArrays.Note that with Nulls.jl master, things like
[1, null] == [1, null]throw becauseif nullis an error. We could probably fix that by providing a special method for==(::AbstractArray{:>Null}, ::AbstractArray), but that would cover==(::Array{Any}, ::Array{Any})... We should discuss that in Nulls.jl. Tests do not appear to cover this, so we should add a few when it works.