Use nonmissingtype instead of Missings.T #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter is deprecated since Julia now exports nonmissingtype. Missings defines nonmissingtype on previous Julia versions. Also simplify the code a bit: there's no need to check T >: Missing before calling nonmissingtype, as it is the identity for other types.
bkamins
approved these changes
Sep 4, 2019
|
Failure is due to a deprecation warning printed by CategoricalArrays in a log test. JuliaData/CategoricalArrays.jl#205 should fix this. |
|
OK, but then we should first release CategoricalArrays.jl and then change the Project.toml in this PR to require its proper version also. Right? |
|
I don't think we need to require that version: the test failure doesn't reflect a real issue, it's just due to how we test that warnings are printed. |
|
OK |
|
CategoricalArrays tagged: JuliaRegistries/General#3292 |
|
Looks good to be merged. |
nalimilan
added a commit
that referenced
this pull request
Sep 6, 2019
The latter is deprecated since Julia now exports nonmissingtype. Missings defines nonmissingtype on previous Julia versions. Also simplify the code a bit: there's no need to check T >: Missing before calling nonmissingtype, as it is the identity for other types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latter is deprecated since Julia now exports
nonmissingtype.Missings defines
nonmissingtypeon previous Julia versions.Also simplify the code a bit: there's no need to check
T >: Missingbefore callingnonmissingtype, as it is the identity for other types.Waiting for JuliaRegistries/General#3224.