Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct documentation typos #3305

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Correct documentation typos #3305

merged 2 commits into from
Mar 29, 2023

Conversation

Naunet
Copy link
Contributor

@Naunet Naunet commented Mar 20, 2023

No description provided.

@Naunet Naunet marked this pull request as ready for review March 20, 2023 14:18
@@ -268,8 +268,8 @@ produce errors as the keys defined in both source data frames were unique.

## Renaming joined columns

Often you want to keep track of the source data frame of a given column.
This feature is supported with the `ranamecols` keyword argument:
Often you want to keep track of the source data frame.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add of what. I understand that you prefer to say "of columns that you do not perform join on"?

@bkamins bkamins added the doc label Mar 20, 2023
@bkamins bkamins added this to the patch milestone Mar 20, 2023
@bkamins bkamins merged commit 5152da5 into JuliaData:main Mar 29, 2023
@bkamins
Copy link
Member

bkamins commented Mar 29, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants