Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct documentation typos #3305

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Correct documentation typos #3305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f55b23
Join doc typos
Naunet Mar 20, 2023
716d13d
fix typo
Naunet Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ It is recommended to add the header `# Examples` above the doctests.
* If you make a PR please try to avoid pushing many small commits to GitHub in
a sequence as each such commit triggers a separate CI job, which takes over
an hour. This has a consequence of making other PRs in packages from the JuliaData
ecosystem wait for such CI jobs to finish as hey share a common pool of CI resources.
ecosystem wait for such CI jobs to finish as they share a common pool of CI resources.

## Style Guidelines

Expand Down
4 changes: 2 additions & 2 deletions docs/src/man/joins.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,8 +268,8 @@ produce errors as the keys defined in both source data frames were unique.

## Renaming joined columns

Often you want to keep track of the source data frame of a given column.
This feature is supported with the `ranamecols` keyword argument:
Often you want to keep track of the source data frame.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add of what. I understand that you prefer to say "of columns that you do not perform join on"?

This feature is supported with the `renamecols` keyword argument:

```jldoctest joins
julia> innerjoin(a, b, on=:ID, renamecols = "_left" => "_right")
Expand Down