Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Float64 parsing error #25

Closed
tk3369 opened this issue Apr 12, 2019 · 1 comment
Closed

Float64 parsing error #25

tk3369 opened this issue Apr 12, 2019 · 1 comment

Comments

@tk3369
Copy link

tk3369 commented Apr 12, 2019

From JuliaData/CSV.jl#397

Base.parse works correctly but Parsers.parse failed:

julia> Base.parse(Float64, "74810199.033988851037472901827191090834")
7.481019903398885e7

julia> Parsers.parse(Float64, "74810199.033988851037472901827191090834")
ERROR: InexactError: check_top_bit(Int64, -3)
Stacktrace:
 [1] throw_inexacterror(::Symbol, ::Any, ::Int64) at ./boot.jl:583
 [2] check_top_bit at ./boot.jl:597 [inlined]
 [3] toUInt64 at ./boot.jl:708 [inlined]
 [4] Type at ./boot.jl:738 [inlined]
 [5] convert at ./number.jl:7 [inlined]
 [6] cconvert at ./essentials.jl:355 [inlined]
 [7] mul_2exp! at ./gmp.jl:146 [inlined]
 [8] mul_2exp! at ./gmp.jl:148 [inlined]
 [9] scale at /Users/tomkwong/.julia/packages/Parsers/v5u2B/src/floats.jl:96 [inlined]
 [10] scale at /Users/tomkwong/.julia/packages/Parsers/v5u2B/src/floats.jl:114 [inlined]
 [11] #_defaultparser#46(::UInt8, ::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}, ::Function, ::Parsers.StringBuffer, ::Parsers.Result{Float64}, ::Type{Int128}) at /Users/tomkwong/.julia/packages/Parsers/v5u2B/src/floats.jl:196
 [12] (::getfield(Parsers, Symbol("#kw##_defaultparser")))(::NamedTuple{(:decimal,),Tuple{UInt8}}, ::typeof(Parsers._defaultparser), ::Parsers.StringBuffer, ::Parsers.Result{Float64}, ::Type{Int128}) at ./none:0
 [13] #_defaultparser#46 at /Users/tomkwong/.julia/packages/Parsers/v5u2B/src/floats.jl:194 [inlined]
 [14] _defaultparser at /Users/tomkwong/.julia/packages/Parsers/v5u2B/src/floats.jl:126 [inlined]
 [15] #defaultparser#45 at /Users/tomkwong/.julia/packages/Parsers/v5u2B/src/floats.jl:123 [inlined]
 [16] defaultparser at /Users/tomkwong/.julia/packages/Parsers/v5u2B/src/floats.jl:123 [inlined]
 [17] #parse!#13 at /Users/tomkwong/.julia/packages/Parsers/v5u2B/src/Parsers.jl:349 [inlined]
 [18] parse! at /Users/tomkwong/.julia/packages/Parsers/v5u2B/src/Parsers.jl:349 [inlined]
 [19] #parse#15 at /Users/tomkwong/.julia/packages/Parsers/v5u2B/src/Parsers.jl:351 [inlined]
 [20] parse at /Users/tomkwong/.julia/packages/Parsers/v5u2B/src/Parsers.jl:351 [inlined]
 [21] #parse#16(::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}, ::Function, ::Type{Float64}, ::String) at /Users/tomkwong/.julia/packages/Parsers/v5u2B/src/Parsers.jl:362
 [22] parse(::Type{Float64}, ::String) at /Users/tomkwong/.julia/packages/Parsers/v5u2B/src/Parsers.jl:361
@quinnj
Copy link
Member

quinnj commented Apr 19, 2019

I think I have a fix for this locally; adding more tests

@quinnj quinnj closed this as completed in 7033abb Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants