Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no type annotations #26

Open
isaac-rstor opened this issue Sep 24, 2018 · 1 comment
Open

no type annotations #26

isaac-rstor opened this issue Sep 24, 2018 · 1 comment

Comments

@isaac-rstor
Copy link

Note that differentiation rules are purely symbolic, so no type annotations should be used.

should some of the differentiation rules like (+)(a,b) -> (1, 1) use the one(a), function instead? Some types might deliberately not implement implicit integer conversion.

@jrevels
Copy link
Member

jrevels commented Sep 24, 2018

Possibly. This is at least something that needs deciding - how tied to "Julia" is the DiffRules format? If it's agnostic, we should keep 1 and then downstream consumers can convert how they'd like. Otherwise, we should probably change many other things in order to better support Julia-specific code generation. I think we're moving in that direction anyway...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants