Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce the size of the type space #10

Merged
merged 2 commits into from
Mar 1, 2018
Merged

reduce the size of the type space #10

merged 2 commits into from
Mar 1, 2018

Conversation

ChrisRackauckas
Copy link
Member

No description provided.

@ChrisRackauckas ChrisRackauckas mentioned this pull request Feb 28, 2018
Closed
@AleMorales
Copy link
Contributor

Why not allow passing value or value_type through the different wrappers around Variable? (i.e. Parameters, DependentVariable, etc)

@ChrisRackauckas
Copy link
Member Author

What do you mean?

@AleMorales
Copy link
Contributor

At the moment if I want to create a Parameter without deafult value I do Parameter(:p) but if I want it to have a default value I need to do Variable(:p, :Parameter, 1.0, Float64). Not a big deal of course, just thinking whether this was on purpose and I am misinterpreting value and value_type

@ChrisRackauckas
Copy link
Member Author

oh yes, those just need to be functions with default values.

@ChrisRackauckas ChrisRackauckas merged commit dc828fe into master Mar 1, 2018
@ChrisRackauckas ChrisRackauckas deleted the small_type branch March 1, 2018 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisRackauckas @AleMorales