truncated negative autocorealation #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By definition, autocorrelation functions start from 1, so positive. You only need to find the index when it first becomes negative. You can also do this in 1 line of code using |
|
Fixed! |
|
Great, but there is still no test calling this new method! Please add a test to the appropriate file in the tests folder. |
Datseris
reviewed
Apr 4, 2023
Comment on lines
+55
to
+56
| idx = findfirst(<(0), c) | ||
| τ = exponential_decay_fit(τs[:idx], c[:idx]) |
There was a problem hiding this comment.
Here idx is the first index that c is negative. So by doing c[1:idx] you will for sure include the negative value. You need to do c[1:idx-1]. Also, please explicitly always include starting index, this [:idx] is python syntax.
|
bump @denizhanpak |
1 similar comment
|
bump @denizhanpak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on issue #64