Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slashes removed in #380 #384

Closed
karajan9 opened this issue Mar 23, 2023 · 2 comments · Fixed by #385
Closed

Slashes removed in #380 #384

karajan9 opened this issue Mar 23, 2023 · 2 comments · Fixed by #385

Comments

@karajan9
Copy link
Contributor

Describe the bug
PR #380 removed a trailing slash from projectdir and, by extension, datadir etc. This is breaking for me, since my paths aren't valid anymore, while before they were.

Minimal Working Example

datadir("folder/")
Expected:
".../data/folder/"
Currently:
".../data/folder"

Since this breaks previously working code (in a patch release no less, 2.12.1 to 2.12.2) I believe this should be reverted.

@karajan9 karajan9 changed the title Slashes removed Slashes removed in #380 Mar 23, 2023
@Datseris
Copy link
Member

Yes, I'll fix this. Hm PR#380 was weird now that I think about it. the author made the change necessary to fix the original issue #181, but also changed the projectdir behavior. The projectdir change was not necessary as far as I can tell.

@karajan9
Copy link
Contributor Author

Thanks for the instant fix and release! I can confirm this fixed the issue for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants