-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to Issue#181 #380
Merged
Merged
Fix to Issue#181 #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datseris
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do find this helpful! Thanks!
Codecov Report
@@ Coverage Diff @@
## main #380 +/- ##
=======================================
Coverage 90.82% 90.82%
=======================================
Files 8 8
Lines 752 752
=======================================
Hits 683 683
Misses 69 69
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my fix #181.
Using the mentioned
rstrip()
for the creation of the default value offilename
inresult_colletion.jl
the described error will no longer occur.By also adding
rstrip()
toprojectdir()
function, the error is also fixed ifcollect_results!()
is called using defined variables usingdatadir()
(as is done inupdate_results_tests.jl
).To demonstrate that, I included a test within
update_resluts_tests.jl
that checks if the bugged file is created.In the case that the wrongly named and placed file is created, the test will remove it anyways, since it would interfere with the test regarding the dimensions of the dataframes (e.g.
@test size(cres2) == (6, 7)
).I hope you will find this helpful!