Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to Issue#181 #380

Merged
merged 14 commits into from
Mar 14, 2023
Merged

Fix to Issue#181 #380

merged 14 commits into from
Mar 14, 2023

Conversation

Myrkwid
Copy link
Contributor

@Myrkwid Myrkwid commented Mar 13, 2023

This is my fix #181.
Using the mentioned rstrip() for the creation of the default value of filename in result_colletion.jl the described error will no longer occur.
By also adding rstrip() to projectdir() function, the error is also fixed if collect_results!() is called using defined variables using datadir() (as is done in update_results_tests.jl).
To demonstrate that, I included a test within update_resluts_tests.jl that checks if the bugged file is created.
In the case that the wrongly named and placed file is created, the test will remove it anyways, since it would interfere with the test regarding the dimensions of the dataframes (e.g. @test size(cres2) == (6, 7)).

I hope you will find this helpful!

Copy link
Member

@Datseris Datseris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do find this helpful! Thanks!

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #380 (f96a51a) into main (6d95eb1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #380   +/-   ##
=======================================
  Coverage   90.82%   90.82%           
=======================================
  Files           8        8           
  Lines         752      752           
=======================================
  Hits          683      683           
  Misses         69       69           
Impacted Files Coverage Δ
src/result_collection.jl 98.18% <ø> (ø)
src/project_setup.jl 87.57% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle trailing slashes in collect_results!
2 participants