-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change internal representation of composition #8
Comments
I'd like to experiment with compositional data kriging, using GeoStats.jl, in the future. |
Oh that is nice! I had this application in mind as well. It would be great if you could push it forward and see if it already works, or what needs to be changed to make it work. The idea of working with composition objects and Julia generics is that we don't need to know about the internal representation of the type. I think the transformations Hopefully we will be able to just have a spatial set of composition objects and feed it into Kriging without issues. But let's see how it goes. :) |
I did some refactoring, and ended up preserving the internal c = Composition(a=1.0, b=2.0, c=missing)
c.a == 1
c.b == 2
ismissing(c.c) and currently it loops in the names of the parts until it finds the symbol. Maybe the compiler is optimizing this loop given that everything is static. I didn't have time to check though. |
I think we can drop the dependency on static arrays and use plain named tuples moving forward. Given that composition objects are never treated as plain vectors, we don't gain much from the default linear algebra behavior of static arrays.
The text was updated successfully, but these errors were encountered: