Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FFMPEG to use 6.1.1 #59

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

theogf
Copy link

@theogf theogf commented Feb 16, 2024

Updated compat and removed avresample reference: https://bugs.gentoo.org/722274

Project.toml Outdated Show resolved Hide resolved
@theogf
Copy link
Author

theogf commented Feb 16, 2024

It looks like OpenSSL has a compatibility issue in 1.3. The version needed by FFMPEG_jll does not exist for 1.3


[deps]
FFMPEG_jll = "b22a6f82-2f65-5046-a5b2-351ab43fb4e5"

[compat]
FFMPEG_jll = "4.3.1"
FFMPEG_jll = "4.3.1, 6.1.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm.. I'm not sure about adding this in a patch release.

At least can we check VideoIO.jl tests before releasing this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm.. I'm not sure about adding this in a patch release.

I agree, that would also mean moving the julia bound to 1.6

At least can we check VideoIO.jl tests before releasing this

By this do you mean testing locally?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also move to v1.0.0 altogether, to avoid the mess of using only two version numbers, this package hasn't been touched in 3 years, looks moderately stable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By this do you mean testing locally?

You could edit the VideoIO CI to dev this branch and test on a PR

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also move to v1.0.0 altogether, to avoid the mess of using only two version numbers, this package hasn't been touched in 3 years, looks moderately stable.

I see there are these drone CI running on Julia 1.3 - 1.5, can I remove it safely?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Drone service is completely broken, just remove it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also remove AppVeyor as the service in Julia is unmaintained and version still refers to 1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ffmpeg binary version?
3 participants