Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[registry] Add OpenEXR via ImageIO #328

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

twadleigh
Copy link
Contributor

@twadleigh twadleigh commented May 3, 2021

Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add one test case for this to make sure future development doesn't break the functionality.

See #323 for an example.

@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #328 (34bfe65) into master (9b94990) will decrease coverage by 0.74%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
- Coverage   88.09%   87.34%   -0.75%     
==========================================
  Files          10       10              
  Lines         655      656       +1     
==========================================
- Hits          577      573       -4     
- Misses         78       83       +5     
Impacted Files Coverage Δ
src/registry.jl 89.65% <ø> (ø)
src/deprecated.jl 47.82% <0.00%> (-10.87%) ⬇️
src/types.jl 88.46% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b94990...34bfe65. Read the comment docs.

@johnnychen94 johnnychen94 changed the title Add OpenEXR via ImageIO. [registry] Add OpenEXR via ImageIO. May 13, 2021
@johnnychen94 johnnychen94 mentioned this pull request May 13, 2021
5 tasks
@johnnychen94
Copy link
Member

@twadleigh any plans to make it work in ImageIO in the near future? I ask this because there are some other PRs here and it's likely to tag a new release in 7 days.

@twadleigh
Copy link
Contributor Author

@twadleigh any plans to make it work in ImageIO in the near future? I ask this because there are some other PRs here and it's likely to tag a new release in 7 days.

I do plan to get to it at some point. Just waiting for a sufficiently large block of leisure time. Probably within the next week or two.

Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With JuliaIO/ImageIO.jl#30 merged, this PR is ready to merge.

@johnnychen94 johnnychen94 changed the title [registry] Add OpenEXR via ImageIO. [registry] Add OpenEXR via ImageIO Aug 19, 2021
@johnnychen94 johnnychen94 merged commit 2db9d89 into JuliaIO:master Aug 19, 2021
@twadleigh twadleigh deleted the add-openexr branch August 19, 2021 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants