condition H5F_LIBVER_LATEST and friends on libversion #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musm
reviewed
May 14, 2018
src/HDF5.jl
Outdated
| @@ -252,8 +252,15 @@ const H5T_NATIVE_UINT64 = read_const(:H5T_NATIVE_UINT64_g) | |||
| const H5T_NATIVE_FLOAT = read_const(:H5T_NATIVE_FLOAT_g) | |||
| const H5T_NATIVE_DOUBLE = read_const(:H5T_NATIVE_DOUBLE_g) | |||
| # Library versions | |||
| const H5F_LIBVER_EARLIEST = 0 | |||
| const H5F_LIBVER_LATEST = 1 | |||
| if HDF5.libversion >= v"1.10.2" | |||
There was a problem hiding this comment.
This should only need libversion not HDF5.libversion, since the constant is defined in the module
|
thnx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #474